Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS Elasticache #414

Merged
merged 10 commits into from
Jul 17, 2024
Merged

Add AWS Elasticache #414

merged 10 commits into from
Jul 17, 2024

Conversation

cduhn17
Copy link
Collaborator

@cduhn17 cduhn17 commented Jul 8, 2024

🗣 Description

AWS Elasticache will be added with a new terraform .tf file

💭 Motivation and context

Elasticache is needed to handle frontend data requests in a timely manner

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@cduhn17 cduhn17 marked this pull request as ready for review July 16, 2024 17:05
@cduhn17 cduhn17 self-assigned this Jul 17, 2024
@cduhn17 cduhn17 added blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use upstream update This issue or pull request pulls in upstream updates terraform Pull requests that update Terraform code labels Jul 17, 2024
hawkishpolicy
hawkishpolicy approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nickviola
nickviola approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 5d13bee into develop Jul 17, 2024
13 of 17 checks passed
@schmelz21 schmelz21 deleted the cd_add_elasticache branch July 17, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkishpolicy hawkishpolicy hawkishpolicy approved these changes

@nickviola nickviola nickviola approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@cduhn17 cduhn17

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use terraform Pull requests that update Terraform code upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cduhn17 @nickviola @hawkishpolicy @schmelz21